spaces-X commented on code in PR #65355:
URL: https://github.com/apache/doris/pull/65355#discussion_r3548506025
##########
be/src/storage/segment/column_reader.cpp:
##########
@@ -1171,12 +1171,22 @@ Status MapFileColumnIterator::next_batch(size_t* n,
MutableColumnPtr& dst, bool*
key_ptr->insert_many_defaults(num_items);
val_ptr->insert_many_defaults(num_items);
} else {
- size_t num_read = num_items;
- bool key_has_null = false;
- bool val_has_null = false;
- RETURN_IF_ERROR(_key_iterator->next_batch(&num_read, key_ptr,
&key_has_null));
- RETURN_IF_ERROR(_val_iterator->next_batch(&num_read, val_ptr,
&val_has_null));
- DCHECK(num_read == num_items);
+ auto read_or_fill_child = [&](ColumnIterator* iterator,
+ MutableColumnPtr& column) -> Status {
+ if (_read_phase == ReadPhase::LAZY && read_meta_columns &&
+ iterator->read_requirement() == ReadRequirement::SKIP) {
+ column->insert_many_defaults(num_items);
+ return Status::OK();
+ }
+
+ bool dummy_has_null = false;
+ size_t num_read = num_items;
+ RETURN_IF_ERROR(iterator->next_batch(&num_read, column,
&dummy_has_null));
+ DCHECK(num_read == num_items);
+ return Status::OK();
+ };
+ RETURN_IF_ERROR(read_or_fill_child(_key_iterator.get(), key_ptr));
Review Comment:
this PR looks like it overlaps almost entirely with #65344 — both seem
to fix the same bug？
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
