seawinde commented on code in PR #65076: URL: https://github.com/apache/doris/pull/65076#discussion_r3548754486
########## be/test/storage/segment/row_binlog_segment_writer_test.cpp: ########## @@ -0,0 +1,120 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +#include <gtest/gtest.h> + +#include <memory> +#include <string> +#include <vector> + +#include "core/field.h" +#include "core/value/decimalv2_value.h" +#include "storage/binlog.h" +#include "storage/iterator/olap_data_convertor.h" +#include "storage/segment/row_binlog_segment_writer.h" +#include "storage/tablet/tablet_schema.h" + +namespace doris::segment_v2 { + +namespace { + +TabletColumn create_column(int32_t unique_id, const std::string& name, FieldType type, bool is_key, + bool visible) { Review Comment: There was no existing row_binlog_segment_writer_test.cpp in this branch, so I moved the RowBinlogSourceDataWriter cases into a new row_binlog_segment_writer_test.cpp and renamed the test suite to RowBinlogSegmentWriterTest. The tested helper is implemented inside row_binlog_segment_writer.cpp, so I think keeping these cases under row_binlog_segment_writer_test matches the intent. Does this look like what you expected, or would you prefer a different existing test suite/class? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
