github-actions[bot] commented on code in PR #65400:
URL: https://github.com/apache/doris/pull/65400#discussion_r3549345423
##########
fe/fe-core/src/main/java/org/apache/doris/catalog/FunctionToSqlConverter.java:
##########
@@ -79,6 +79,7 @@ public static String toSql(ScalarFunction fn, boolean
ifNotExists) {
boolean isReturnNull = fn.getNullableMode() ==
NullableMode.ALWAYS_NULLABLE;
sb.append(",\n \"ALWAYS_NULLABLE\"=").append("\"" + isReturnNull
+ "\"");
sb.append(",\n \"VOLATILITY\"=").append("\"" +
fn.getVolatility().toSql() + "\"");
+ sb.append(",\n \"STATIC_LOAD\"=").append("\"" + fn.isStaticLoad()
+ "\"");
Review Comment:
This now prints `STATIC_LOAD` for Java table functions too, but the UDTF
create path never copies the parsed value into the catalog function.
`analyzeCommon()` parses `"static_load"="true"` into `isStaticLoad`, yet
`analyzeUdtf()` only sets checksum, nullable mode, the UDTF flag, runtime
code/version, and volatility; unlike `analyzeUdf()`/`analyzeUdaf()`, it does
not call `setStaticLoad(isStaticLoad)` or copy the expiration time. A `CREATE
TABLES FUNCTION ... "static_load"="true"` therefore stores `false`, so `SHOW
CREATE TABLES FUNCTION` and replayed DDL now expose and preserve the wrong
value. Please copy the Java UDTF static-load metadata in `analyzeUdtf()` and
add UDTF display/round-trip coverage.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
