github-actions[bot] commented on code in PR #65330:
URL: https://github.com/apache/doris/pull/65330#discussion_r3549890782
##########
cloud/src/recycler/recycler.cpp:
##########
@@ -844,6 +844,10 @@ int InstanceRecycler::do_recycle() {
int InstanceRecycler::recycle_deleted_instance() {
LOG_WARNING("begin to recycle deleted instance").tag("instance_id",
instance_id_);
+ if (instance_info_.recycled_status() ==
InstanceDeletedStatus::INSTANCE_META_AND_DATA_DELETED) {
Review Comment:
This guard is too late for the normal recycler path. `recycle_callback()`
always calls `InstanceRecycler::init()` before `do_recycle()`, but the metadata
phase removes the `storage_vault_key` range and leaves only the instance KV
with `INSTANCE_META_AND_DATA_DELETED`. On the next scanner pass, a
storage-vault instance still has `resource_ids()`, so
`init_storage_vault_accessors()` scans the now-empty vault range, returns `-2`
because `accessor_map_` is empty, and the worker never reaches this no-op
check. That leaves fully recycled instances being retried as init failures
forever. Please skip terminal deleted instances before
constructing/initializing `InstanceRecycler`, or make `init()` bypass accessor
loading when the deleted recycle status is already terminal.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
