github-actions[bot] commented on code in PR #65375:
URL: https://github.com/apache/doris/pull/65375#discussion_r3551934573
##########
regression-test/suites/partition_p0/auto_partition/test_auto_new_recycle.groovy:
##########
@@ -113,6 +116,16 @@ suite("test_auto_new_recycle", "nonConcurrent") {
waitUntilSafeExecutionTime("NOT_CROSS_DAY_BOUNDARY", 20)
+ def waitPartitionCount = { int expectedCount ->
Review Comment:
The longer poll makes this final `now()`-based case much easier to race with
midnight. The only guard is still
`waitUntilSafeExecutionTime("NOT_CROSS_DAY_BOUNDARY", 20)`, but this helper can
now wait up to 1200 seconds, and this final call replaces a fixed 8-second
sleep after inserting `date_add(now(), interval number-5 day)`. The recycle
code decides whether a partition is historical using the scheduler's current
time, so if the rows are inserted shortly before midnight and this await
observes the recycle after midnight, the partition for the insert day becomes
historical and retention can leave 5 partitions instead of the asserted 6.
Please either make this case use a fixed base date/time or move/resize the
day-boundary guard so it covers the maximum wait through this final assertion.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
