github-actions[bot] commented on code in PR #65397:
URL: https://github.com/apache/doris/pull/65397#discussion_r3552732460
##########
regression-test/data/external_table_p0/iceberg/test_iceberg_invaild_avro_name.out:
##########
@@ -1,7 +1,7 @@
-- This file is automatically generated. You should know what you did if you
want to edit this
-- !desc --
id int Yes true \N
-test:a1b2.raw.abc-gg-1-a text Yes true \N
+TEST:A1B2.RAW.ABC-GG-1-A text Yes true \N
Review Comment:
`git diff --check` fails on this generated output because the changed
`TEST:A1B2.RAW.ABC-GG-1-A` row still ends with a trailing tab. The same
trailing tab is present in the second changed desc row at line 32, so CI/style
checks that run the whitespace gate will reject the PR until these
expected-output lines are regenerated or trimmed.
##########
fe/be-java-extensions/paimon-scanner/src/main/java/org/apache/doris/paimon/PaimonJniScanner.java:
##########
@@ -183,15 +349,23 @@ private int readAndProcessNextBatch() throws IOException {
appendData(i, columnValue);
}
if (rows >= batchSize) {
+ if (fields.length == 0) {
Review Comment:
This branch still will not run for the empty-projection case coming from BE.
`PaimonJniReader` sends empty slot lists as `required_fields=""` and
`columns_types=""`, but Java `String.split` turns each of those into a
one-element array containing `""`. That leaves `fields.length == 1`, so
`getProjected()` tries to resolve an empty field name and fails with
`RequiredField not found in schema` before the virtual-row path can append
rows. Please normalize empty `required_fields`/`columns_types` to zero-length
arrays in the constructor before parsing the types.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
