github-actions[bot] commented on code in PR #65373:
URL: https://github.com/apache/doris/pull/65373#discussion_r3556297516
##########
regression-test/plugins/plugin_compaction.groovy:
##########
@@ -114,9 +126,12 @@ Suite.metaClass.trigger_and_wait_compaction = { String
table_name, String compac
triggered_tablets.add(tablet) // compaction already in queue,
treat it as successfully triggered
} else if (!auto_compaction_disabled) {
// ignore the error if auto compaction enabled
- } else if (status_lower.contains("e-2000") ||
status_lower.contains("e-2010")) {
+ } else if (status_lower.contains("e-2010")) {
+ // cumulative compaction handed delete-version rowsets to base
compaction, so still wait below.
+ triggered_tablets.add(tablet)
+ } else if (isNoopCompactionStatus(trigger_status.status)) {
Review Comment:
Line 132 now skips any `isNoopCompactionStatus`, including `E-808`, for
every compaction type. For explicit base compaction this is not a benign
completion: `BaseCompaction::pick_rowsets_to_compact()` returns
`BE_NO_SUITABLE_VERSION` when it cannot select the needed base inputs or
rejects delete-predicate/base-policy shapes. Several regression suites use
`trigger_and_wait_compaction(table, "base")` as the proof that base compaction
happened; `test_config_prune_delete_sign.groovy` even notes a cloud base `-808`
means base compaction was not triggered and inserts another row before calling
this helper. With this branch, a regression where base compaction unexpectedly
returns `E-808` will skip the tablet and let later assertions run against
uncompacted rowsets. Please keep trigger-time no-suitable handling
type-specific, or require callers that want to tolerate base `E-808` to pass it
in `ignored_errors`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
