github-actions[bot] commented on code in PR #65448: URL: https://github.com/apache/doris/pull/65448#discussion_r3556891085
########## docker/compilation/Dockerfile: ########## @@ -55,6 +53,12 @@ RUN wget https://nodejs.org/download/release/latest-v14.x/node-v14.21.3-linux-x6 && cp -r node-v14.21.3-linux-x64/* /usr/local/ \ && rm /tmp/node-v14.21.3-linux-x64.tar.gz && rm -rf node-v14.21.3-linux-x64 +# install Rust for lance-c +ARG RUST_TOOLCHAIN="1.91.0" Review Comment: The image installs Rust 1.91.0, but the locked Rust dependency graph already requires a newer compiler. In `be/src/rust/doris-native`, `cargo +1.91.0 check --locked` fails before compiling with `aws-config`, `aws-credential-types`, `aws-runtime`, `aws-sdk-*`, and related `aws-smithy-*` crates requiring rustc 1.91.1. Since this Dockerfile also puts `/root/.cargo/bin` on the final compilation image PATH, any build path that enables the Lance/Rust readers and relies on this toolchain will fail at the MSRV check. Please install at least 1.91.1 here, or avoid hard-coding a lower version than the workspace/dependencies require. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
