github-actions[bot] commented on code in PR #61156:
URL: https://github.com/apache/doris/pull/61156#discussion_r3557025119
##########
regression-test/suites/query_p0/sql_functions/string_functions/test_string_function_regexp.groovy:
##########
@@ -128,6 +128,22 @@ suite("test_string_function_regexp") {
qt_sql_regexp_extract_all_9 "SELECT REGEXP_EXTRACT_ALL(concat('aXb',
char(10), 'cXd'), '(?-s)(\\\\w.\\\\w)');"
qt_sql_regexp_extract_all_10 "SELECT REGEXP_EXTRACT_ALL(concat('aXb',
char(10), 'cXd'), '(\\\\w.\\\\w)');"
+ test {
+ sql 'SELECT REGEXP_EXTRACT_ALL_ARRAY(\'Apache/Doris\',
\'([a-zA-Z_+-]+(?:\\/[a-zA-Z_0-9+-]+)*)(?=s|$)\');'
+ exception "Invalid regex pattern"
+ }
+ qt_regexp_extract_all_array_1 "SELECT
regexp_extract_all_array('x=a3&x=18abc&x=2&y=3&x=4&x=17bcd',
'x=([0-9]+)([a-z]+)');"
+ qt_regexp_extract_all_array_2 "SELECT
regexp_extract_all_array('http://a.m.baidu.com/i41915i73660.htm', 'i([0-9]+)');"
+ qt_regexp_extract_all_array_3 "SELECT regexp_extract_all_array('abc=111,
def=222, ghi=333', '(\"[^\"]+\"|\\\\w+)=(\"[^\"]+\"|\\\\w+)');"
+ qt_regexp_extract_all_array_4 "select
regexp_extract_all_array('xxfs','f');"
+ qt_regexp_extract_all_array_5 "select regexp_extract_all_array(NULL,
'pattern');"
+ qt_regexp_extract_all_array_6 "select regexp_extract_all_array('text',
NULL);"
+ qt_regexp_extract_all_array_7 "select
regexp_extract_all_array('abcdfesscca', '(ab|c|)');"
+ qt_regexp_extract_all_array_8 "SELECT regexp_extract_all_array(k,
'(\\\\w+)') from test_string_function_regexp ORDER BY k;"
+ qt_regexp_extract_all_array_9 "SELECT regexp_extract_all_array(k,
'([a-z]+)') from test_string_function_regexp ORDER BY k;"
+ qt_regexp_extract_all_array_10 "SELECT k, v, regexp_extract_all_array(k,
'(\\\\w+)') from test_string_function_regexp ORDER BY k;"
Review Comment:
This query projects `v`, but the `ORDER BY` only uses `k`. The fixture
already has two `billie eillish` rows with different `v` values before this
point, and the `.out` file expects those tied rows in a specific order. Please
add a deterministic tie-breaker here, for example `ORDER BY k, v` if that
matches the intended NULL ordering, and regenerate the expected output if it
changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
