deardeng opened a new pull request, #65457:
URL: https://github.com/apache/doris/pull/65457
Related PR: #49569
Problem Summary: Related PR #49569 changed the colocate replica allocation
helper boolean from needEditLog to isReplay, but kept the old call-site values.
As a result, normal ALTER COLOCATE GROUP replica allocation changes were
treated as replay and skipped logColocateModifyRepliaAlloc, so the new replica
allocation was not persisted for follower replay or master failover. The replay
path was treated as a normal operation and could append another edit log while
loading journal entries. This patch flips the two call-site values: leader
ALTER uses isReplay = false and writes the edit log, while replay uses isReplay
= true and does not append a new edit log. It also adds FE unit tests covering
both behaviors.
### What problem does this PR solve?
Issue Number: close #xxx
Related PR: #xxx
Problem Summary:
### Release note
None
### Check List (For Author)
- Test <!-- At least one of them must be included. -->
- [ ] Regression test
- [x] Unit Test
- [ ] Manual test (add detailed scripts or steps below)
- [ ] No need to test or manual test. Explain why:
- [ ] This is a refactor/code format and no logic has been changed.
- [ ] Previous test can cover this change.
- [ ] No code files have been changed.
- [ ] Other reason <!-- Add your reason? -->
- Behavior changed:
- [x] No.
- [ ] Yes. <!-- Explain the behavior change -->
- Does this need documentation?
- [x] No.
- [ ] Yes. <!-- Add document PR link here. eg:
https://github.com/apache/doris-website/pull/1214 -->
### Check List (For Reviewer who merge this PR)
- [ ] Confirm the release note
- [ ] Confirm test cases
- [ ] Confirm document
- [ ] Add branch pick label <!-- Add branch pick label that this PR should
merge into -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
