github-actions[bot] commented on code in PR #65420:
URL: https://github.com/apache/doris/pull/65420#discussion_r3557395816
##########
be/src/io/fs/s3_obj_storage_client.cpp:
##########
@@ -86,17 +86,23 @@ auto s3_rate_limit(doris::S3RateLimitType op, Func
callback) -> decltype(callbac
if (sleep_duration < 0) {
return T(s3_error_factory());
}
+ if (bytes > 0) {
Review Comment:
The byte limiter only gets charged on the native S3 path. Azure still uses
the same `enable_s3_rate_limiter`/`S3ClientFactory::rate_limiter()` helper, but
its `put_object`, `upload_part`, and `get_object` calls never pass
`stream.size()` or `bytes_read` through `bytes_rate_limiter()`. With the new
positive defaults for `s3_get_bytes_per_second_per_core` and
`s3_put_bytes_per_second_per_core`, enabling the rate limiter now throttles S3
bandwidth but silently leaves Azure bandwidth unlimited. Please either apply
the same byte accounting to the Azure read/write helpers or make these new
configs/API explicitly S3-native so Azure users do not expect them to apply.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
