spaces-X commented on code in PR #65484:
URL: https://github.com/apache/doris/pull/65484#discussion_r3566624014
##########
fe/fe-core/src/main/java/org/apache/doris/alter/AlterOperations.java:
##########
@@ -113,7 +113,8 @@ public boolean checkBinlogConfigChange(List<AlterOp>
alterOps) {
).anyMatch(clause ->
clause.getProperties().containsKey(PropertyAnalyzer.PROPERTIES_BINLOG_ENABLE)
||
clause.getProperties().containsKey(PropertyAnalyzer.PROPERTIES_BINLOG_TTL_SECONDS)
||
clause.getProperties().containsKey(PropertyAnalyzer.PROPERTIES_BINLOG_MAX_BYTES)
- ||
clause.getProperties().containsKey(PropertyAnalyzer.PROPERTIES_BINLOG_MAX_HISTORY_NUMS));
+ ||
clause.getProperties().containsKey(PropertyAnalyzer.PROPERTIES_BINLOG_MAX_HISTORY_NUMS)
+ ||
clause.getProperties().containsKey(PropertyAnalyzer.PROPERTIES_BINLOG_FORMAT));
Review Comment:
binlog.`need_historical_value seems` to have the same routing gap as
binlog.format. ModifyTablePropertiesOp.validate() treats it as a binlog
property, and BinlogConfig.mergeFromProperties(..., false) explicitly rejects
changing it, but checkBinlogConfigChange() still routes it through the generic
schema-change path. Could we include PROPERTIES_BINLOG_NEED_HISTORICAL_VALUE
here and add the parallel test?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
