github-actions[bot] commented on code in PR #65516: URL: https://github.com/apache/doris/pull/65516#discussion_r3568245707
########## docker/compilation/Dockerfile: ########## @@ -55,6 +53,12 @@ RUN wget https://nodejs.org/download/release/latest-v14.x/node-v14.21.3-linux-x6 && cp -r node-v14.21.3-linux-x64/* /usr/local/ \ && rm /tmp/node-v14.21.3-linux-x64.tar.gz && rm -rf node-v14.21.3-linux-x64 +# install Rust for lance-c +ARG RUST_TOOLCHAIN="1.91.0" Review Comment: The image now preinstalls only `RUST_TOOLCHAIN=1.91.0`, but the Rust workspace that this image is meant to support has `be/src/rust/doris-native/rust-toolchain.toml` selecting `channel = "stable"`. When `BUILD_RUST_READERS=ON` and there is no prebuilt `libdoris_ffi.a`, `be/cmake/rust.cmake` imports the crate through Corrosion, and Corrosion runs cargo from the workspace manifest directory so rustup honors that toolchain file. In a fresh image after this install, rustup only has `1.91.0`, so the later BE build asks rustup for `stable` instead of using the preinstalled toolchain; that either downloads another toolchain during the build or fails in offline/pinned environments. Please install the same toolchain the workspace selects, or pin both the Docker ARG and `rust-toolchain.toml` to the same exact version. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
