yiguolei commented on code in PR #65268:
URL: https://github.com/apache/doris/pull/65268#discussion_r3568407335
##########
be/src/storage/segment/vertical_segment_writer.cpp:
##########
@@ -1345,25 +1348,37 @@ Status
VerticalSegmentWriter::finalize_columns_index(uint64_t* index_size) {
RETURN_IF_ERROR(_write_short_key_index());
*index_size = _file_writer->bytes_appended() - index_start;
}
+ uint64_t file_index_end = _file_writer->bytes_appended();
+ _index_file_cache_info.add_index_range(index_start, file_index_end -
index_start);
// reset all column writers and data_conveter
clear();
return Status::OK();
}
-Status VerticalSegmentWriter::finalize_footer(uint64_t* segment_file_size) {
+Status VerticalSegmentWriter::finalize_footer(uint64_t* segment_file_size,
+ SegmentIndexFileCacheInfo*
index_file_cache_info) {
+ uint64_t footer_start = _file_writer->bytes_appended();
RETURN_IF_ERROR(_write_footer());
// finish
RETURN_IF_ERROR(_file_writer->close(true));
*segment_file_size = _file_writer->bytes_appended();
+ // The closed size completes the preload range recorded above.
SegmentIndexFileCacheLoader
+ // later decides whether this is a remote cloud rowset that should
actually be preloaded.
+ _index_file_cache_info.segment_file_size = *segment_file_size;
+ _index_file_cache_info.add_index_range(footer_start, *segment_file_size -
footer_start);
+ if (index_file_cache_info != nullptr) {
Review Comment:
不要加这种代码，外面不要传递一个nullptr 作为返回值。
把需要传递nullptr的地方，都传递一个空的SegmentIndexFileCacheInfo
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
