mrhhsg opened a new pull request, #65526:
URL: https://github.com/apache/doris/pull/65526
### What problem does this PR solve?
Issue Number: None
Related PR: #65263
Problem Summary:
Expression ZoneMap filtering was enabled by default when it was introduced
on branch-4.1. This change disables `enable_expr_zonemap_filter` for regular
new sessions and assigns it with `Random.nextBoolean()` in fuzzy mode, so fuzzy
testing exercises both enabled and disabled paths with equal probability.
The dedicated expression ZoneMap regression suites now enable the session
variable explicitly, keeping their profile-counter assertions deterministic
regardless of the global default or fuzzy-mode randomization.
For mixed-version compatibility, the absent Thrift-field behavior remains
legacy-enabled. New FE sessions always serialize the session value explicitly
through `SessionVariable.toThrift()`.
### Release note
Disable expression ZoneMap filtering by default on branch-4.1 while randomly
enabling it in half of fuzzy-mode sessions.
### Check List (For Author)
- Test <!-- At least one of them must be included. -->
- [ ] Regression test
- [x] Unit Test
- [ ] Manual test (add detailed scripts or steps below)
- [ ] No need to test or manual test. Explain why:
- [ ] This is a refactor/code format and no logic has been changed.
- [ ] Previous test can cover this change.
- [ ] No code files have been changed.
- [ ] Other reason
Validation:
- `DORIS_THIRDPARTY=/mnt/disk7/hushenggang/doris-zonemap/thirdparty
./run-fe-ut.sh --run
org.apache.doris.qe.SessionVariablesTest,org.apache.doris.qe.VariableMgrTest`
passed (21 tests).
- `git diff --check` passed.
- Behavior changed:
- [ ] No.
- [x] Yes. Expression ZoneMap filtering is disabled by default for new
sessions and randomized in fuzzy mode.
- Does this need documentation?
- [x] No.
- [ ] Yes.
### Check List (For Reviewer who merge this PR)
- [ ] Confirm the release note
- [ ] Confirm test cases
- [ ] Confirm document
- [ ] Add branch pick label
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
