github-actions[bot] commented on code in PR #65535:
URL: https://github.com/apache/doris/pull/65535#discussion_r3569391543
##########
regression-test/suites/metrics_p0/test_delete_bitmap_metrics.groovy:
##########
@@ -184,79 +184,90 @@ suite("test_delete_bitmap_metrics", "p0") {
def tablets = sql_return_maparray """ show tablets from ${testTable};
"""
+ tablets.sort { lhs, rhs -> lhs.ReplicaId.toLong() <=>
rhs.ReplicaId.toLong() }
logger.info("tablets: " + tablets)
def local_delete_bitmap_count = 0
def ms_delete_bitmap_count = 0
def local_delete_bitmap_cardinality = 0;
def ms_delete_bitmap_cardinality = 0;
- for (def tablet in tablets) {
- String tablet_id = tablet.TabletId
- def tablet_info = sql_return_maparray """ show tablet
${tablet_id}; """
- logger.info("tablet: " + tablet_info)
- String trigger_backend_id = tablet.BackendId
+ try {
+ for (int ri = 0; ri < tablets.size(); ri++) {
+ // use_fix_replica selects replicas in ReplicaId order.
Populate and
+ // inspect each replica immediately because the agg cache is
an LRU.
+ sql "set use_fix_replica=${ri};"
+ sql "select * from ${testTable};"
Review Comment:
This still looks flaky when cloud multi-replica placement is enabled. The
test records `tablet.BackendId` from `SHOW TABLETS`, then warms with
`use_fix_replica=${ri}` and probes `/count_agg_cache` on that stored backend.
In cloud mode, though, `CloudTablet` has one logical `CloudReplica`, and
`CloudReplica.getBackendIdImpl()` chooses a physical BE with
`rand.nextInt(Config.cloud_replica_num)` on each backend-resolution call when
`enable_cloud_multi_replica` is true. The `SHOW TABLETS` call and the later
scan can therefore pick different physical BEs, while `/count_agg_cache` only
snapshots the target BE's local agg cache. Please either pin/disable cloud
multi-replica for this per-BE cache assertion, or query the actual BE selected
by the warmup scan before checking its cache.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
