github-actions[bot] commented on code in PR #65543:
URL: https://github.com/apache/doris/pull/65543#discussion_r3569677222
##########
regression-test/suites/show_p0/test_show_create_table_and_views_nereids.groovy:
##########
@@ -99,7 +115,7 @@ suite("test_show_create_table_and_views_nereids", "show") {
(2, 200, 1111),
(23, 900, 1)"""
- qt_show "SHOW CREATE TABLE ${dbName}.${tableName}"
Review Comment:
This still leaves the cloud P0 run broken.
`cloud_p0/conf/regression-conf-custom.groovy` runs group `p0`, and the
framework adds `p0` to this suite from the `show_p0` directory, so the suite is
selected there. In that environment `cloud_unique_id` makes
`Config.isCloudMode()` true, and `Env.addOlapTablePropertyInfo()` emits
`file_cache_ttl_seconds` instead of
`replication_allocation`/`min_load_replica_num` for `SHOW CREATE TABLE`. The
new `show_*_replica_1`/`3` blocks only contain the non-cloud property list, so
the first `quickRunTest` will compare cloud output against the non-cloud golden
before reaching the later checks. Please add/select cloud-specific SHOW CREATE
blocks, skip this suite in cloud mode, or normalize the properties being
compared.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
