eldenmoon commented on code in PR #65561: URL: https://github.com/apache/doris/pull/65561#discussion_r3575729344
########## be/src/core/data_type/data_type_variant.cpp: ########## @@ -24,27 +24,72 @@ #include <string.h> #include <cassert> +#include <limits> #include <memory> #include <utility> #include <vector> #include "agent/be_exec_version_manager.h" +#include "common/exception.h" #include "core/assert_cast.h" #include "core/column/column.h" +#include "core/column/column_const.h" +#include "core/column/column_nullable.h" +#include "core/column/column_string.h" #include "core/column/column_variant.h" +#include "core/column/column_variant_v2.h" #include "core/data_type/data_type.h" #include "core/data_type/data_type_factory.hpp" +#include "core/data_type/data_type_jsonb.h" +#include "core/data_type/data_type_nullable.h" +#include "core/data_type/data_type_variant_v2_exchange.h" Review Comment: 这个最好不叫v2_exchange，直接放到v2_serde ########## be/src/core/data_type/data_type_variant.cpp: ########## @@ -24,27 +24,72 @@ #include <string.h> #include <cassert> +#include <limits> #include <memory> #include <utility> #include <vector> #include "agent/be_exec_version_manager.h" +#include "common/exception.h" #include "core/assert_cast.h" #include "core/column/column.h" +#include "core/column/column_const.h" +#include "core/column/column_nullable.h" +#include "core/column/column_string.h" #include "core/column/column_variant.h" +#include "core/column/column_variant_v2.h" #include "core/data_type/data_type.h" #include "core/data_type/data_type_factory.hpp" +#include "core/data_type/data_type_jsonb.h" +#include "core/data_type/data_type_nullable.h" +#include "core/data_type/data_type_variant_v2_exchange.h" Review Comment: 这个最好不叫v2_exchange，相关接口直接放到v2_serde -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
