github-actions[bot] commented on code in PR #65553:
URL: https://github.com/apache/doris/pull/65553#discussion_r3575915355
##########
fe/fe-core/src/main/java/org/apache/doris/load/routineload/RoutineLoadJob.java:
##########
@@ -977,13 +980,18 @@ private void updateNumOfData(long numOfTotalRows, long
numOfErrorRows, long unse
"current error rows is more than max_error_number "
+ "or the max_filter_ratio is more than the value
set"), isReplay);
}
- // reset currentTotalNum, currentErrorNum and otherMsg
- this.jobStatistic.currentErrorRows = 0;
- this.jobStatistic.currentTotalRows = 0;
- this.otherMsg = "";
+ resetCurrentErrorStatistics();
}
}
+ private void resetCurrentErrorStatistics() {
+ this.jobStatistic.currentErrorRows = 0;
+ this.jobStatistic.currentTotalRows = 0;
+ this.otherMsg = "";
+ this.errorLogUrls.clear();
Review Comment:
This helper now clears the existing `ERROR_LOG_URLS` queue whenever the
current error-stat window is reset. Before this refactor these branches only
reset `currentErrorRows`, `currentTotalRows`, and `otherMsg`; the last three
error-log URLs stayed visible in `SHOW ROUTINE LOAD` and
`information_schema.routine_load_jobs`. A later successful/no-error batch can
cross the `currentTotalRows > maxBatchRows * 10` reset path with no new
`errorLogUrl` to add back, so the public `ERROR_LOG_URLS` diagnostic becomes
blank even though the earlier bad-row URL is still the latest error URL. Please
preserve `errorLogUrls` across current-stat resets, or make this public
diagnostic lifetime change explicit and covered by tests; `FIRST_ERROR_MSG` can
be reset separately if that field is intended to track only the current window.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
