sollhui commented on PR #65555: URL: https://github.com/apache/doris/pull/65555#issuecomment-4965459458
Thanks for making the replay path tolerant of a missing routine load job. This prevents FE startup from being blocked by an orphan `OP_CHANGE_ROUTINE_LOAD_JOB`. However, this appears to address the replay symptom without explaining how the orphan journal entry is generated. Could you please clarify the root cause and the exact ordering that allows a change operation to remain after the job has been removed? For example, is there a race between transitioning a job to a final state and `cleanOldRoutineLoadJobs()` / `cleanOverLimitRoutineLoadJobs()` that may produce `OP_REMOVE_ROUTINE_LOAD_JOB` before `OP_CHANGE_ROUTINE_LOAD_JOB`? If Doris can still generate this ordering, should we also fix the journal ordering or locking to prevent new orphan entries, instead of relying only on replay-time tolerance? A focused unit test covering the missing-job replay case would also be helpful. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
