yiguolei commented on code in PR #65324:
URL: https://github.com/apache/doris/pull/65324#discussion_r3577358982
##########
be/src/exec/operator/data_queue.h:
##########
@@ -82,17 +91,14 @@ class DataQueue {
DataQueue(int child_count = 1);
~DataQueue() = default;
- Status get_block_from_queue(std::unique_ptr<Block>* block, int* child_idx
= nullptr);
- Status push_block(std::unique_ptr<Block> block, int child_idx = 0);
+ Result<DataQueueBlock> get_block_from_queue();
+ Status push_block(std::unique_ptr<Block> block, int child_idx, bool eos);
std::unique_ptr<Block> get_free_block(int child_idx = 0);
- void push_free_block(std::unique_ptr<Block> output_block, int child_idx =
0);
+ void push_free_block(DataQueueBlock&& queue_block);
- void set_finish(int child_idx = 0);
bool is_all_finish();
Review Comment:
is_all_finish and has_more_data only used for debug string. We could add a
debug string api directly. And not expose these APIs because other logic may
depend on these API if it is public.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
