github-actions[bot] commented on code in PR #65304:
URL: https://github.com/apache/doris/pull/65304#discussion_r3578103394
##########
thirdparty/build-thirdparty.sh:
##########
@@ -2166,6 +2239,7 @@ if [[ "${#packages[@]}" -eq 0 ]]; then
cares
grpc # after cares, protobuf
arrow
Review Comment:
Once `lance_c` is in the default package list, every Dockerfile that runs
the default `thirdparty/build-thirdparty.sh` needs Cargo available, because
`build_lance_c` exits immediately when `cargo` is missing. The main compilation
image was updated with an `install Rust for lance-c` block, but the ARM and
legacy GCC image builders still invoke the default third-party build without
installing Rust/Cargo. Those image builds will now fail before producing
`thirdparty/installed`. Please provision Rust/Cargo 1.91+ in the ARM/gcc7/gcc10
compilation Dockerfiles too, or keep `lance_c` out of those default builds
until the toolchain is guaranteed.
##########
thirdparty/build-thirdparty.sh:
##########
@@ -2166,6 +2239,7 @@ if [[ "${#packages[@]}" -eq 0 ]]; then
cares
grpc # after cares, protobuf
arrow
+ lance_c
Review Comment:
Once `lance_c` is in the default package list, every Dockerfile that runs
the default `thirdparty/build-thirdparty.sh` needs Cargo available, because
`build_lance_c` exits immediately when `cargo` is missing. The main compilation
image was updated with an `install Rust for lance-c` block, but the ARM and
legacy GCC image builders still invoke the default third-party build without
installing Rust/Cargo. Those image builds will now fail before producing
`thirdparty/installed`. Please provision Rust/Cargo 1.91+ in the ARM/gcc7/gcc10
compilation Dockerfiles too, or keep `lance_c` out of those default builds
until the toolchain is guaranteed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
