github-actions[bot] commented on code in PR #65556:
URL: https://github.com/apache/doris/pull/65556#discussion_r3584194843
##########
regression-test/suites/insert_p0/test_insert_visible_timeout_return_mode.groovy:
##########
@@ -44,8 +37,9 @@ suite("test_insert_visible_timeout_return_mode",
"nonConcurrent") {
"""
try {
- // Block FE publish so inserts can commit but remain non-visible until
the debug point is removed.
- DebugPoint.enableDebugPoint(feHost, feHttpPort, NodeType.FE,
debugPoint)
+ // PublishVersionDaemon only runs on the master FE. Enable the debug
point on every FE so the
+ // case does not depend on whether the regression runner is connected
to a master or follower FE.
+ GetDebugPoint().enableDebugPointForAllFEs(debugPoint)
Review Comment:
This regresses the address handling the deleted code was avoiding.
`enableDebugPointForAllFEs` builds its targets from `SHOW FRONTENDS` via
`Suite.getFrontendIpHttpPort()`, but those rows are not guaranteed to be HTTP
endpoints reachable from the regression runner: the removed code was explicitly
using `context.config.feHttpAddress` because `SHOW FRONTENDS` may expose
loopback addresses, and `FrontendsProcNode` also reports the connected FE's
`HttpURLUtil.getHttpPort()` for each row. In those multi-FE/container setups
this call can post to the wrong or unreachable endpoint before the test reaches
the insert checks; if cleanup later aborts in the same all-FE loop, the master
can keep `PublishVersionDaemon.stop_publish` enabled because this call has no
timeout and the cleanup exception is only logged. Please target the master
through a reachable address mapping, or make the all-FE helper use reachable FE
HTTP endpoints and add bounded/robust cleanup for this debug point.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
