github-actions[bot] commented on code in PR #65480:
URL: https://github.com/apache/doris/pull/65480#discussion_r3584294517
##########
regression-test/suites/external_table_p0/hive/test_orc_lazy_mat_profile.groovy:
##########
@@ -134,9 +135,14 @@ suite("test_orc_lazy_mat_profile", "p0,external") {
Review Comment:
This still does not prove the profile you are checking came from ScannerV2.
The suite now sets `enable_file_scanner_v2`, but all of the counters asserted
below (`FilteredRowsByLazyRead`, `EvaluatedRowGroupCount`,
`SelectedRowGroupCount`) are also registered by the legacy ORC reader, so the
test could keep passing if this scan silently falls back to the old
`FileScanner` path. Please assert the captured profile contains `UseScannerV2:
true` before checking the ORC counters, like the helper added in
`test_hive_orc_predicate.groovy`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]