CalvinKirs commented on code in PR #65551:
URL: https://github.com/apache/doris/pull/65551#discussion_r3584400645
##########
fe/fe-core/src/main/java/org/apache/doris/common/util/HttpURLUtil.java:
##########
@@ -20,8 +20,10 @@
import org.apache.doris.catalog.Env;
Review Comment:
InternalHttpsUtils only provides the shared SSLContext/truststore for TLS;
HttpURLUtil builds the JDK HttpURLConnection and adds the node-ident + token
headers, delegating TLS to InternalHttpsUtils. They're layered, not duplicated.
The token is an auth header on the checkFromValidFe-protected meta endpoints,
all of which go through HttpURLUtil, and it is sent unconditionally so it rides
over HTTPS as well — so InternalHttpsUtils is orthogonal to this change and
HTTPS works.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
