shuke987 opened a new pull request, #65627:
URL: https://github.com/apache/doris/pull/65627
### What problem does this PR solve?
Issue Number: None
Related PR: #47082
Problem Summary:
`StreamSinkFileWriter` previously implemented the one/two-replica
fault-injection debug points by skipping the first entries in each writer's
local stream order. Writers for the same tablet can have different stream
orders, so they could skip different destination backends. A nominal
one-replica failure could therefore affect two replicas across writers and make
the load lose quorum.
This PR derives the failed replica set from sorted destination backend IDs.
Every writer with the same replica set now skips the same backend(s),
independent of local stream order. It also adds unit coverage for one- and
two-replica injection with reordered stream lists.
Local validation:
- `git diff --cached --check`: passed before commit.
- Added `StreamSinkFileWriterTest` coverage for reordered streams.
- Targeted BE UT execution was attempted, but worktree dependency
initialization failed while cloning `contrib/apache-orc` with `curl 18` /
`early EOF`; CI `run buildall` is requested below for compile and test
validation.
- Official clang-format wrapper could not run because local `llvm@16` was
unavailable; the dependency download stalled. The patch was manually reviewed
and passes `git diff --check`.
### Release note
None
### Check List (For Author)
- Test <!-- At least one of them must be included. -->
- [ ] Regression test
- [x] Unit Test
- [ ] Manual test (add detailed scripts or steps below)
- [ ] No need to test or manual test. Explain why:
- [ ] This is a refactor/code format and no logic has been changed.
- [ ] Previous test can cover this change.
- [ ] No code files have been changed.
- [ ] Other reason <!-- Add your reason? -->
- Behavior changed:
- [x] No. The change only makes test-only debug point behavior
deterministic.
- [ ] Yes. <!-- Explain the behavior change -->
- Does this need documentation?
- [x] No.
- [ ] Yes. <!-- Add document PR link here. eg:
https://github.com/apache/doris-website/pull/1214 -->
### Check List (For Reviewer who merge this PR)
- [ ] Confirm the release note
- [ ] Confirm test cases
- [ ] Confirm document
- [ ] Add branch pick label <!-- Add branch pick label that this PR should
merge into -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
