github-actions[bot] commented on code in PR #65633:
URL: https://github.com/apache/doris/pull/65633#discussion_r3585497374
##########
regression-test/suites/fault_injection_p0/test_incomplete_commit_info.groovy:
##########
@@ -41,7 +41,23 @@ suite("test_incomplete_commit_info", "nonConcurrent") {
) engine=olap
DISTRIBUTED BY HASH(`k1`) BUCKETS 5 properties("replication_num" =
"1")
"""
-
GetDebugPoint().enableDebugPointForAllBEs("VNodeChannel.add_block_success_callback.incomplete_commit_info")
+
+ streamLoad {
+ table "${tableName}"
+ db "regression_test_fault_injection_p0"
+ set 'column_separator', ','
+ file "baseall.txt"
+ }
+
+ def tabletIds = sql_return_maparray("SHOW TABLETS FROM ${tableName}")
+ .collect { it.TabletId }
+ .unique()
+ def tabletId = tabletIds.find {
+ sql("SELECT COUNT(*) FROM ${tableName}
TABLET(${it})")[0][0].toLong() > 0
+ }
+ GetDebugPoint().enableDebugPointForAllBEs(
+
"VNodeChannel.add_block_success_callback.incomplete_commit_info",
+ [tablet_id: "${tabletId}"])
streamLoad {
Review Comment:
This still lets the regression pass for the wrong failure mode.
`StreamLoadAction.checkResult()` calls `waitForPublishOrFailure()` before this
custom check; when the original response is `Publish Timeout`, that helper can
return `Fail` after the wait even if the transaction never reached the FE
quorum rejection path, then it rewrites the response status before
`json.Status` is asserted. Since this test is specifically for the missing
`TTabletCommitInfo` path, please also assert a stable part of `json.Message`,
for example `Failed to commit txn` and `succ replica num 0 < load required
replica num 1`, so a publish-timeout or unrelated failure cannot satisfy the
test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
