github-actions[bot] commented on code in PR #65645:
URL: https://github.com/apache/doris/pull/65645#discussion_r3586226097
##########
regression-test/suites/job_p0/streaming_job/cdc/test_streaming_mysql_job_snapshot_with_concurrent_dml.groovy:
##########
@@ -132,8 +232,8 @@
suite("test_streaming_mysql_job_snapshot_with_concurrent_dml", "p0,external,mysq
throw ex
}
- def showUnrelated = sql """show tables from ${currentDb} like
'${unrelated}'"""
- assert showUnrelated.size() == 0
Review Comment:
This test now relies on `${table2}` to cover the cross-table
snapshot/backfill case, but the deterministic regression output below still
only records `${table1}`. The table2 checks in the Awaitility predicate can
make the current run fail, but they do not update the generated `.out`
baseline, so the new second-table scenario is not locked down the same way as
the changed PostgreSQL multi-table test. Please add `qt_` checks for table2
count, updated keys, deleted keys, and inserted rows using `other_id`, then
regenerate `test_streaming_mysql_job_snapshot_with_concurrent_dml.out`.
##########
regression-test/suites/job_p0/streaming_job/cdc/test_streaming_mysql_job_snapshot_with_concurrent_dml.groovy:
##########
@@ -132,8 +232,8 @@
suite("test_streaming_mysql_job_snapshot_with_concurrent_dml", "p0,external,mysq
throw ex
}
- def showUnrelated = sql """show tables from ${currentDb} like
'${unrelated}'"""
- assert showUnrelated.size() == 0
+ def showExcluded = sql """show tables from ${currentDb} like
'${excludedTable}'"""
+ assert showExcluded.size() == 0
qt_select_count """select count(1) from ${currentDb}.${table1}"""
Review Comment:
This test now relies on `${table2}` to cover the cross-table
snapshot/backfill case, but the deterministic regression output below still
only records `${table1}`. The table2 checks in the Awaitility predicate can
make the current run fail, but they do not update the generated `.out`
baseline, so the new second-table scenario is not locked down the same way as
the changed PostgreSQL multi-table test. Please add `qt_` checks for table2
count, updated keys, deleted keys, and inserted rows using `other_id`, then
regenerate `test_streaming_mysql_job_snapshot_with_concurrent_dml.out`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
