jacktengg opened a new pull request, #65679:
URL: https://github.com/apache/doris/pull/65679
Issue Number: None
Related PR: None
Problem Summary:
1. Nereids converted ROWS window offsets through double. Long.MAX_VALUE was
rounded to 2^63 and serialized as Long.MIN_VALUE, causing BE frame arithmetic
to address an invalid LAG default row and crash. Preserve offsets exactly,
reject values larger than INT64_MAX, and make BE frame arithmetic robust to
legacy wrapped plans and signed overflow.
Fix a BE crash for LAG and LEAD with very large offsets and reject ROWS
window offsets greater than INT64_MAX.
2. Nereids checked LEAD and LAG offsets only after function signature
coercion. A decimal offset was therefore converted to BIGINT before validation
and incorrectly accepted. Validate the original offset type before coercion so
non-integer offsets fail during FE analysis, and add regression and unit
coverage for both functions.
- Behavior changed: Yes. ROWS window offsets greater than INT64_MAX are
rejected and report error for non-integer offsets for lead and lag.
- Does this need documentation: No
LEAD and LAG now reject non-integer offset arguments during analysis.
### What problem does this PR solve?
Issue Number: close #xxx
Related PR: #xxx
Problem Summary:
### Release note
None
### Check List (For Author)
- Test <!-- At least one of them must be included. -->
- [ ] Regression test
- [ ] Unit Test
- [ ] Manual test (add detailed scripts or steps below)
- [ ] No need to test or manual test. Explain why:
- [ ] This is a refactor/code format and no logic has been changed.
- [ ] Previous test can cover this change.
- [ ] No code files have been changed.
- [ ] Other reason <!-- Add your reason? -->
- Behavior changed:
- [ ] No.
- [ ] Yes. <!-- Explain the behavior change -->
- Does this need documentation?
- [ ] No.
- [ ] Yes. <!-- Add document PR link here. eg:
https://github.com/apache/doris-website/pull/1214 -->
### Check List (For Reviewer who merge this PR)
- [ ] Confirm the release note
- [ ] Confirm test cases
- [ ] Confirm document
- [ ] Add branch pick label <!-- Add branch pick label that this PR should
merge into -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
