seawinde opened a new pull request, #65686:
URL: https://github.com/apache/doris/pull/65686
### What problem does this PR solve?
Issue Number: N/A
Related PR: #65076, #65663
Problem Summary:
The master BE unit test target fails to compile because
`GroupRowsetWriterTest` still passes a pointer to `allocate_binlog_lsn()`,
which now accepts a vector reference. After fixing compilation, the suite
aborts while flushing row-binlog data.
Root cause: In `GroupRowsetWriterTest.SetUp()`, two columns are removed from
the generated row-binlog schema without updating `binlog_tso_idx`,
`binlog_lsn_idx`, and `binlog_op_idx`. `RowBinlogSegmentWriter` consequently
accesses column ID 7 in a seven-column schema. The test output assertions also
use the previous LSN, operation, and timestamp layout.
This change initializes the shared LSN vector before passing it by
reference, resets the metadata indexes after filtering columns, and verifies
TSO, LSN, and operation values using the current schema order and types.
### Release note
None
### Check List (For Author)
- Test
- [ ] Regression test
- [x] Unit Test
- `./run-be-ut.sh -j 20 --run '--filter=GroupRowsetWriterTest.*'` (3
tests passed)
- [ ] Manual test (add detailed scripts or steps below)
- [ ] No need to test or manual test. Explain why:
- [ ] This is a refactor/code format and no logic has been changed.
- [ ] Previous test can cover this change.
- [ ] No code files have been changed.
- [ ] Other reason
- Behavior changed:
- [x] No.
- [ ] Yes.
- Does this need documentation?
- [x] No.
- [ ] Yes.
### Check List (For Reviewer who merge this PR)
- [ ] Confirm the release note
- [ ] Confirm test cases
- [ ] Confirm document
- [ ] Add branch pick label
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
