freemandealer commented on code in PR #65174:
URL: https://github.com/apache/doris/pull/65174#discussion_r3593267687
##########
be/src/io/cache/block_file_cache_factory.cpp:
##########
@@ -113,13 +104,111 @@ Status FileCacheFactory::create_file_cache(const
std::string& cache_base_path,
<< " total_size: " << file_cache_settings.capacity
<< " disk_total_size: " << disk_capacity;
}
+
auto cache = std::make_unique<BlockFileCache>(cache_base_path,
file_cache_settings);
RETURN_IF_ERROR(cache->initialize());
+ built_cache->cache_base_path = cache_base_path;
+ built_cache->settings = file_cache_settings;
+ built_cache->cache = std::move(cache);
+ return Status::OK();
+}
+
+} // namespace
+
+FileCacheFactory* FileCacheFactory::instance() {
+ return ExecEnv::GetInstance()->file_cache_factory();
+}
+
+size_t FileCacheFactory::try_release() {
+ int elements = 0;
+ for (auto& cache : _caches) {
+ elements += cache->try_release();
+ }
+ return elements;
+}
+
+size_t FileCacheFactory::try_release(const std::string& base_path) {
+ auto iter = _path_to_cache.find(base_path);
+ if (iter != _path_to_cache.end()) {
+ return iter->second->try_release();
+ }
+ return 0;
+}
+
+Status FileCacheFactory::create_file_cache(const std::string& cache_base_path,
+ FileCacheSettings
file_cache_settings) {
+ BuiltFileCache built_cache;
+ RETURN_IF_ERROR(build_file_cache(cache_base_path, file_cache_settings,
&built_cache));
+ {
+ std::lock_guard lock(_mtx);
+ _path_to_cache[built_cache.cache_base_path] = built_cache.cache.get();
+ _capacity += built_cache.settings.capacity;
+ _caches.push_back(std::move(built_cache.cache));
+ }
+
+ return Status::OK();
+}
+
+Status FileCacheFactory::create_file_caches(
+ const std::vector<CachePath>& cache_paths,
+ const std::function<bool(const std::string&, const Status&)>&
should_ignore_error) {
+ struct BuildResult {
+ std::string cache_base_path;
+ FileCacheSettings settings;
+ BuiltFileCache built_cache;
+ Status status;
+ bool skip = false;
+ };
+
+ std::vector<BuildResult> results;
+ results.reserve(cache_paths.size());
+ std::unordered_set<std::string> cache_path_set;
+ for (const auto& cache_path : cache_paths) {
+ if (cache_path_set.find(cache_path.path) != cache_path_set.end()) {
+ LOG(WARNING) << fmt::format("cache path {} is duplicate",
cache_path.path);
+ continue;
+ }
+
+ cache_path_set.emplace(cache_path.path);
+ auto& result = results.emplace_back();
+ result.cache_base_path = cache_path.path;
+ result.settings = cache_path.init_settings();
+ }
+
+ std::vector<std::thread> workers;
+ workers.reserve(results.size());
+ for (auto& result : results) {
+ auto* result_ptr = &result;
+ workers.emplace_back([result_ptr]() {
Review Comment:
fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
