github-actions[bot] commented on code in PR #65691:
URL: https://github.com/apache/doris/pull/65691#discussion_r3593456793


##########
regression-test/suites/auth_call/test_ddl_restore_auth.groovy:
##########
@@ -17,7 +17,7 @@
 
 import java.util.UUID
 
-suite("test_ddl_restore_auth", "p0,auth_call,nonConcurrent") {
+suite("test_ddl_restore_auth", "p0,auth_call") {

Review Comment:
   [P1] Cover both lock directions before enabling this suite
   
   Moving this suite into the NORMAL pool still leaves supported executions 
vulnerable to the same timeout in both directions. `CREATE REPOSITORY` holds 
`RepositoryMgr.lock` across S3 initialization, so a concurrent patched `DROP` 
can acquire `BackupHandler.seqlock` and then block on that manager lock; this 
suite's unretried `BACKUP`/`RESTORE` can then time out after 10 seconds. 
Conversely, on `--times > 1` or a retained cluster, `test_show_repository_auth` 
has a retained fixed repository, its `try_sql(DROP)` can time out behind this 
suite and be swallowed, and its next `CREATE` fails as already existing. The 
new loop protects only one DROP call. Please either keep `nonConcurrent`, or 
apply the exact transient retry to every required setup/drop plus this suite's 
expected-success BACKUP/RESTORE statements before parallelizing it.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to