github-actions[bot] commented on code in PR #65672:
URL: https://github.com/apache/doris/pull/65672#discussion_r3594425039
##########
regression-test/suites/compaction/test_compaction_uniq_keys_with_delete.groovy:
##########
@@ -120,29 +121,43 @@ suite("test_compaction_uniq_keys_with_delete") {
//TabletId,ReplicaId,BackendId,SchemaHash,Version,LstSuccessVersion,LstFailedVersion,LstFailedTime,LocalDataSize,RemoteDataSize,RowCount,State,LstConsistencyCheckTime,CheckVersion,VersionCount,PathHash,MetaUrl,CompactionStatus
def tablets = sql_return_maparray """ show tablets from ${tableName};
"""
- def replicaNum = get_table_replica_num(tableName)
- logger.info("get table replica num: " + replicaNum)
+ def isCompactedEnough = { tabletJson ->
+ def versionRanges = ((List<String>) tabletJson.rowsets).collect {
rowset ->
+ rowset.split(" ")[0]
+ }
+ logger.info("rowset version ranges after cumulative compaction: "
+ versionRanges)
+ def rangeBounds = versionRanges.collect { range ->
+ def matcher = range =~ /\[(\d+)-(\d+)\]/
+ assert matcher.matches()
+ [Integer.parseInt(matcher[0][1]),
Integer.parseInt(matcher[0][2])]
+ }
Review Comment:
The `11` endpoint only holds while this table uses non-light DELETE, but the
DDL does not pin that behavior: new UNIQUE tables are MOW by default, and an
absent `enable_mow_light_delete` inherits the mutable FE-wide setting. If that
setting is true, the middle otherwise-empty DELETE uses `DeleteHandler` and
publishes a predicate version, so this sequence ends at 12 and the wait can
never pass. Please set `"enable_mow_light_delete" = "false"` on this table (the
CK variant already pins `true`) so the asserted endpoint is deterministic.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
