github-actions[bot] commented on code in PR #65718:
URL: https://github.com/apache/doris/pull/65718#discussion_r3595383199
##########
fe/fe-core/src/main/java/org/apache/doris/datasource/jdbc/JdbcExternalTable.java:
##########
@@ -149,7 +152,7 @@ public Optional<SchemaCacheValue> initSchema() {
}
// 1. Retrieve remote column information
- List<Column> columns = ((JdbcExternalCatalog)
catalog).listColumns(remoteDbName, remoteName);
+ List<Column> columns = ((JdbcExternalCatalog)
catalog).listColumns(remoteDbName, remoteTableName);
Review Comment:
[P2] Make the fallback metadata lookup exact, not another JDBC pattern —
This effective name is still passed as `DatabaseMetaData.getColumns`'s
`tableNamePattern`, where `_` and `%` are wildcards. The generic and other
unfiltered vendor paths consume every returned row without checking
`TABLE_NAME`, so the test's own `local_table` name can also pull columns from a
sibling such as `localXtable`. With a missing `remoteName`, this still builds a
combined/wrong schema or raises a false conflict instead of resolving the
target table. PostgreSQL already exact-filters the returned schema/table fields
for this case; please make the clients reached here exact as well and add a
metadata-level regression with a wildcard-bearing name plus a sibling.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
