github-actions[bot] commented on code in PR #65731:
URL: https://github.com/apache/doris/pull/65731#discussion_r3597013680
##########
be/test/common/status_test.cpp:
##########
@@ -117,6 +139,13 @@ TEST_F(StatusTest, Error) {
}
}
+TEST_F(StatusTest, EmptyCapturedStackTrace) {
+ ScopedEmptyStackTraceFault fault;
+
+ Status status = Status::NotFound("fault-injected empty stack trace");
+ EXPECT_NE(status.to_string().find("<Empty trace>"), std::string::npos);
Review Comment:
The fault point runs after `frame_count` has already been normalized and
forces only `size = 0`, so this test would still pass if negative-return
normalization regressed; it also never exercises short non-empty/exact-skip
traces or the new offset rebasing at `stack_trace.cpp:499`. Those are separate
behaviors claimed by this PR, and Doris requires kernel fixes to have direct
tests. Please add deterministic cases for negative/zero/positive capture
normalization and for sizes around the three-frame skip with offsets
before/equal/after the slice (a small helper or `StackTrace(NoCapture)` test
can avoid depending on real unwinding).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
