0AyanamiRei commented on code in PR #65420:
URL: https://github.com/apache/doris/pull/65420#discussion_r3597845297
##########
common/cpp/token_bucket_rate_limiter.cpp:
##########
@@ -127,30 +127,35 @@ int64_t TokenBucketRateLimiter::add(size_t amount) {
TokenBucketRateLimiterHolder::TokenBucketRateLimiterHolder(size_t max_speed,
size_t max_burst,
size_t limit,
std::function<void(int64_t)> metric_func)
- : rate_limiter(std::make_unique<TokenBucketRateLimiter>(max_speed,
max_burst, limit)),
+ : rate_limiter(std::make_shared<TokenBucketRateLimiter>(max_speed,
max_burst, limit)),
+ _enabled(max_speed > 0 || limit > 0),
metric_func(std::move(metric_func)) {}
int64_t TokenBucketRateLimiterHolder::add(size_t amount) {
return add_with_config(amount).sleep_duration;
}
TokenBucketRateLimiterResult
TokenBucketRateLimiterHolder::add_with_config(size_t amount) {
- TokenBucketRateLimiterResult result;
+ std::shared_ptr<TokenBucketRateLimiter> limiter;
{
std::shared_lock read {rate_limiter_rw_lock};
- result = {.sleep_duration = rate_limiter->add(amount),
- .max_speed = rate_limiter->get_max_speed(),
- .max_burst = rate_limiter->get_max_burst(),
- .limit = rate_limiter->get_limit()};
+ limiter = rate_limiter;
}
+ TokenBucketRateLimiterResult result = {.sleep_duration =
limiter->add(amount),
+ .max_speed =
limiter->get_max_speed(),
+ .max_burst =
limiter->get_max_burst(),
+ .limit = limiter->get_limit()};
metric_func(result.sleep_duration);
return result;
}
int TokenBucketRateLimiterHolder::reset(size_t max_speed, size_t max_burst,
size_t limit) {
+ auto new_rate_limiter =
+ std::make_shared<TokenBucketRateLimiter>(max_speed, max_burst,
limit);
{
std::unique_lock write {rate_limiter_rw_lock};
- rate_limiter = std::make_unique<TokenBucketRateLimiter>(max_speed,
max_burst, limit);
+ rate_limiter = std::move(new_rate_limiter);
Review Comment:
maybe we dont need to care this problem？
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
