github-actions[bot] commented on code in PR #65746:
URL: https://github.com/apache/doris/pull/65746#discussion_r3600326973
##########
cloud/test/recycler_test.cpp:
##########
@@ -8601,10 +8605,10 @@ TEST(RecyclerTest,
recycle_txn_label_deal_with_conflict_error_test) {
std::make_shared<TxnLazyCommitter>(mem_txn_kv));
ASSERT_EQ(recycler.init(), 0);
- // deal with conflict but error during recycle
+ // Propagate a recycle error without relying on an internal label conflict.
ASSERT_EQ(recycler.recycle_expired_txn_label(), -1);
Review Comment:
The new assertion confirms that grouping eliminates internal same-label
conflicts, but the negative-path coverage has disappeared.
`delete_recycle_txn_kv_error` now runs immediately after the initial delete and
forces that successful result to `-1`, so this test never enters `ret == 1`; it
also has only one label group and checks neither the residual KVs nor a clean
rerun after the worker stops. Thus successful retry, retry exhaustion,
sibling-group cancellation, and restart safety are all unprotected even though
external label writers can still conflict. Please add deterministic
`before_commit` label-key mutations for one-conflict success and
repeated-conflict exhaustion, plus a multi-group one-shot failure that verifies
retained metadata and later cleanup.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
