github-actions[bot] commented on code in PR #65700:
URL: https://github.com/apache/doris/pull/65700#discussion_r3600974602
##########
fe/pom.xml:
##########
@@ -304,7 +304,7 @@ under the License.
<!--Need to ensure that the version is the same as in
arrow/java/pom.xml or compatible with it.-->
<grpc.version>1.65.1</grpc.version>
<check.freamework.version>3.53.0</check.freamework.version>
- <cel.version>0.12.0</cel.version>
+ <cel.version>0.13.1</cel.version>
Review Comment:
[P1] Preserve the persisted CEL dialect during rolling upgrades
CEL 0.13.x broadens the default language: for example, the standard compiler
now accepts `timestamp(0)`, while 0.12.0 rejects that overload. RoleMappingMgr
validates a mapping only on the creating FE and journals the source expression;
replay stores it without compilation, and DefinitionBackedRoleMappingEvaluator
recompiles it locally on first authentication. During a rolling FE upgrade, a
new master can therefore persist a mapping that works on upgraded nodes but
becomes MISCONFIGURED and rejects authentication on an older node. Please keep
compiler/runtime options on a 0.12-compatible dialect until mixed versions are
impossible, or version/gate persisted expressions, and add a cross-version
compatibility test.
##########
fe/pom.xml:
##########
@@ -264,7 +264,7 @@ under the License.
<cglib.version>2.2</cglib.version>
<commons-cli.version>1.4</commons-cli.version>
<commons-filerupload.version>1.6.0</commons-filerupload.version>
- <commons-configuration2.version>2.11.0</commons-configuration2.version>
+ <commons-configuration2.version>2.15.1</commons-configuration2.version>
Review Comment:
[P1] Align Commons Text with Configuration 2.15.1
Upgrading Configuration alone leaves the effective reactor graph
binary-incompatible: this POM still manages Commons Text at 1.10.0, while
Configuration 2.15.1 is compiled against 1.15.0. Its StringLookupAdapter now
invokes StringLookup.apply(String), which is absent in Text 1.10.0. Hadoop
3.4.2's MetricsConfig.loadFirst calls interpolatedConfiguration(), and with the
effective Doris versions a normal `${sys:user.home}` value throws
NoSuchMethodError. Please align the managed Commons dependencies (at minimum
Text, and verify Lang/IO as well) or select a Configuration release compatible
with the existing pins, and add an interpolation smoke test using the effective
reactor classpath.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
