hutiefang76 commented on code in PR #65484:
URL: https://github.com/apache/doris/pull/65484#discussion_r3604308652
##########
fe/fe-core/src/main/java/org/apache/doris/alter/AlterOperations.java:
##########
@@ -113,7 +113,8 @@ public boolean checkBinlogConfigChange(List<AlterOp>
alterOps) {
).anyMatch(clause ->
clause.getProperties().containsKey(PropertyAnalyzer.PROPERTIES_BINLOG_ENABLE)
||
clause.getProperties().containsKey(PropertyAnalyzer.PROPERTIES_BINLOG_TTL_SECONDS)
||
clause.getProperties().containsKey(PropertyAnalyzer.PROPERTIES_BINLOG_MAX_BYTES)
- ||
clause.getProperties().containsKey(PropertyAnalyzer.PROPERTIES_BINLOG_MAX_HISTORY_NUMS));
+ ||
clause.getProperties().containsKey(PropertyAnalyzer.PROPERTIES_BINLOG_MAX_HISTORY_NUMS)
+ ||
clause.getProperties().containsKey(PropertyAnalyzer.PROPERTIES_BINLOG_FORMAT));
Review Comment:
Fixed in f366927c29. `PROPERTIES_BINLOG_NEED_HISTORICAL_VALUE` now uses the
same binlog-config route as `binlog.format`. I added a routing unit test and an
ALTER TABLE integration test that verifies the existing
`BinlogConfig.mergeFromProperties(..., false)` error (`not support change
binlog.need_historical_value from false to true`). The four focused
format/historical-value tests pass, Maven validate reports 0 Checkstyle
violations, and `git diff --check` passes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
