Gabriel39 commented on code in PR #65674:
URL: https://github.com/apache/doris/pull/65674#discussion_r3609621537
##########
be/src/format_v2/table/hudi_reader.cpp:
##########
@@ -66,7 +73,13 @@ Status HudiHybridReader::init(format::TableReadOptions&&
options) {
}
Status HudiHybridReader::prepare_split(const format::SplitReadOptions&
options) {
- RETURN_IF_ERROR(_ensure_current_split_reader(options));
+ {
+ // Child readers use these same counters, so time only
dispatch/creation here and end the
+ // outer scopes before invoking the child to preserve single-counted
totals.
+ SCOPED_TIMER(_profile.total_timer);
+ SCOPED_TIMER(_profile.prepare_split_timer);
Review Comment:
Fixed in 53c50ab1f20. Hudi and Paimon hybrid dispatch no longer nests the
shared TableReader timers around child initialization. Added deterministic
first-native/first-JNI profile delta tests for both hybrid readers; the full
related ASAN set passes 116/116.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
