wenzhenghu commented on issue #65750:
URL: https://github.com/apache/doris/issues/65750#issuecomment-5015378843
Update: item 1 in this issue is fixed by the current FE patch set.
What changed:
- `AlterTableEvent.processRename()` no longer short-circuits on target-name
existence. It now always converges local state by unregistering the old table
name and registering the new table name.
- `AlterDatabaseEvent.processRename()` now follows the same converge-state
pattern for database rename.
- The old `tableExistInLocal()` helper chain has been removed entirely
because it no longer has any production callers.
Why this closes item 1:
- The original bug was not only the load-through local-existence check
itself, but also the broader race where the target name could already be hot
before the HMS rename event arrived.
- The new logic makes rename handling idempotent and cache-state convergent,
so both cases are covered: the target may be cold or already hot, but the old
local name/object/id mapping and engine cache are still cleaned up.
Validation:
- Added FE event-level tests covering:
- table rename with cold target
- table rename with already-hot target
- database rename with cold target
- database rename with already-hot target
- The cold-target tests also assert that the event publishes the new name/id
mapping without warming the cold object cache.
Status of the remaining items in this issue:
- Item 2: not addressed by this patch set.
- Item 3: still open; incremental CREATE_DATABASE/CREATE_TABLE visibility
filtering still needs a separate fix.
- Item 4: not addressed by this patch set.
So this issue should remain open, but item 1 can be considered resolved.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
