github-actions[bot] commented on code in PR #65674:
URL: https://github.com/apache/doris/pull/65674#discussion_r3610422509
##########
be/src/format_v2/orc/orc_reader.cpp:
##########
@@ -803,20 +806,20 @@ void OrcReader::_init_profile() {
_profile, "EvaluatedRowGroupCount", TUnit::UNIT, orc_profile, 1);
_orc_profile.read_row_count =
ADD_CHILD_COUNTER_WITH_LEVEL(_profile, "ReadRowCount",
TUnit::UNIT, orc_profile, 1);
- _orc_profile.filtered_row_groups = ADD_CHILD_COUNTER_WITH_LEVEL(_profile,
"RowGroupsFiltered",
-
TUnit::UNIT, orc_profile, 1);
+ _orc_profile.filtered_row_groups = ADD_CHILD_COUNTER_WITH_LEVEL(
Review Comment:
[P2] Keep ORC pruning counters below OrcReader
These changes move `RowGroupsFiltered`, `RowGroupsReadNum`, and the other
pruning counters out of the `OrcReader` subtree, so even an ORC-only profile no
longer attributes this format-owned work to the documented format node. They
also do not become reliable common aggregates: `RuntimeProfile` is globally
keyed by counter name, and Parquet registers the same names below
`ParquetReader`, so a Parquet-first mixed scan makes ORC reuse those pointers
and report its updates under `ParquetReader`. Please retain format-specific
children (and use separately named common totals if needed), with an ORC
hierarchy test plus both mixed initialization orders.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
