wenzhenghu commented on PR #65126: URL: https://github.com/apache/doris/pull/65126#issuecomment-5015525954
Follow-up from the final review: the MetaCacheEntry migration covers the direct ExternalCatalog/ExternalDatabase name and object caches, but these four entries are still outside ExternalMetaCacheMgr.getCatalogCacheStats(catalogId). I created #65792 to track adding them to the unified statistics path. This is an observability completeness follow-up rather than a correctness blocker for this PR. The follow-up should collect only already-local state and must not initialize a catalog, enumerate remote metadata, load objects, or otherwise warm a cold cache while collecting statistics. The three remaining HMS event findings from the same review are already tracked by #65750 (items 2, 3, and 4). The rename finding in item 1 is addressed by the current PR update. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
