Gabriel39 commented on code in PR #65784:
URL: https://github.com/apache/doris/pull/65784#discussion_r3610465729


##########
fe/fe-core/src/main/java/org/apache/doris/datasource/iceberg/source/IcebergScanNode.java:
##########
@@ -549,12 +552,16 @@ Map<Integer, String> 
getBase64EncodedInitialDefaultsForScan() throws UserExcepti
             // schema that produced source.getTargetTable().getColumns() to 
keep defaults aligned.
             return 
IcebergUtils.getBase64EncodedInitialDefaults(icebergTable.schema());
         }
+        IcebergTableQueryInfo selectedSnapshot = getSpecifiedSnapshot();
+        if (selectedSnapshot == null) {
+            // A schema-only update does not create a data snapshot. Ordinary 
scans expose current
+            // table columns, so their default metadata must come from that 
same current schema.
+            return 
IcebergUtils.getBase64EncodedInitialDefaults(icebergTable.schema());

Review Comment:
   Fixed in b4909eb6c09. Ordinary scans now resolve initial-default metadata 
from the same statement-pinned Iceberg MVCC schema ID that produced the target 
columns, so a cache invalidation cannot advance the marker schema mid-scan. 
Added a cache-refresh regression test; the full IcebergScanNodeTest suite 
passes 16/16 without the Maven build cache.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to