github-actions[bot] commented on code in PR #65591:
URL: https://github.com/apache/doris/pull/65591#discussion_r3612527427
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/rules/rewrite/AccessPathExpressionCollector.java:
##########
@@ -642,11 +665,36 @@ public Void visitIsNull(IsNull isNull, CollectorContext
context) {
CollectorContext nullContext =
new CollectorContext(context.statementContext,
context.bottomFilter);
nullContext.accessPathBuilder.addSuffix(AccessPathInfo.ACCESS_NULL);
+ nullContext.setType(ColumnAccessPathType.META);
return continueCollectAccessPath(arg, nullContext);
}
return visit(isNull, context);
}
+ /**
+ * Resolve the StructField selected by a constant int/string literal.
+ * Returns null when the selector is not a recognized literal or index is
out of bounds.
+ */
+ /** VisibleForTesting */
Review Comment:
[P1] Keep the method Javadoc attached to its declaration
The required CheckStyle job on this exact head fails with
`InvalidJavadocPosition` at line 674 because this second Javadoc block
separates the method's main Javadoc from `resolveStructField`. Please merge the
testing note into the first block, replace it with the project's annotation, or
remove it so the FE style gate can pass.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
