eldenmoon commented on code in PR #65561: URL: https://github.com/apache/doris/pull/65561#discussion_r3613216900
########## be/src/util/variant/variant_encoded_block.h: ########## @@ -0,0 +1,82 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +#pragma once + +#include <cstddef> +#include <cstdint> +#include <memory> +#include <span> + +#include "core/string_ref.h" +#include "util/variant/variant_metadata.h" +#include "util/variant/variant_value.h" + +namespace doris { + +class VariantBlockBuilder; +struct VariantEncodedBlockStorage; + +// Borrows one immutable shared-metadata encoding unit. Offsets are directly compatible with +// ColumnString and always contain num_rows() + 1 entries. +class VariantEncodedBlockView { Review Comment: 删除 VariantEncodedBlockStorage； 保留 VariantEncodedBlock 作为真正的 owner； metadata、values、offsets 直接成为 owner 的成员； 保持“owner move 会使旧 view/ref 失效”的现有契约； 补充 small metadata/value、empty block 和 move 后新 owner 可用的单测。 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
