CalvinKirs commented on PR #65644:
URL: https://github.com/apache/doris/pull/65644#issuecomment-5031797458
Addressed the "don't touch the pre-existing plugin" feedback.
`SCH_PLUGINS` / `information_schema.plugins` is the pre-existing MySQL
compatibility placeholder and must stay untouched. The previous revision
renamed it in place to `SCH_EXTENSIONS`, repurposing a slot that does not
belong to this feature.
Fixed:
- Restored `SCH_PLUGINS = 15` (thrift `TSchemaTableType`) and
`SCH_PLUGINS("PLUGINS", ...)` (FE `SchemaTableType`), byte-identical to
base.
- The extension inventory is now a **new, independent** enum value
`SCH_EXTENSIONS = 73`, appended at the end — it no longer overtakes the
MySQL one.
- The `extensions` system table keeps its own additive wiring
(`TSchemaTableName.EXTENSIONS`, the `extensions` `SchemaTable`), so it is a
fully separate table from MySQL-compat `plugins`.
On the `SOURCE` column: it is not inferred, it is set explicitly at
registration. `registerBuiltin(...)` -> `BUILTIN` (classpath plugins found
via `ServiceLoader`); `registerExternal(...)` -> `EXTERNAL` (jars loaded from
a plugin directory by `DirectoryPluginRuntimeManager`). The registry only
stores that flag.
FE compiles cleanly (thrift regen + enum consistency); BE clang-format fixed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
