Copilot commented on code in PR #676:
URL:
https://github.com/apache/doris-flink-connector/pull/676#discussion_r3626921557
##########
flink-doris-connector/flink-doris-connector-base/src/test/java/org/apache/doris/flink/serialization/TestRowBatch.java:
##########
@@ -1769,6 +1776,7 @@ public void timestampVector() throws IOException,
DorisException {
arrowStreamWriter.start();
root.setRowCount(1);
+ // no tz vector is utc timestamp
Review Comment:
Test comment grammar is unclear; rephrase to clearly state that timestamps
without an embedded timezone are interpreted as UTC.
##########
flink-doris-connector/flink-doris-connector-base/src/main/java/org/apache/doris/flink/serialization/RowBatch.java:
##########
@@ -424,6 +425,7 @@ public boolean doConvert(
}
break;
case "DATETIMEV2":
+ case "TIMESTAMPTZ":
if (minorType.equals(MinorType.VARCHAR)) {
VarCharVector varCharVector = (VarCharVector) fieldVector;
if (varCharVector.isNull(rowIndex)) {
Review Comment:
The error log message in this DATETIMEV2/TIMESTAMPTZ branch always says
"Unsupported type for DATETIMEV2", which is misleading when the schema type is
TIMESTAMPTZ. Logging the actual schema type makes debugging mismatches easier.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
