This is an automated email from the ASF dual-hosted git repository.
yiguolei pushed a commit to branch branch-4.1
in repository https://gitbox.apache.org/repos/asf/doris.git
The following commit(s) were added to refs/heads/branch-4.1 by this push:
new fd47cde7672 branch-4.1: [fix](be) Fix release build warning in column
mapper #65143 (#65845)
fd47cde7672 is described below
commit fd47cde7672d232ffd877fd9a019449d1ac94df2
Author: github-actions[bot]
<41898282+github-actions[bot]@users.noreply.github.com>
AuthorDate: Wed Jul 22 10:37:34 2026 +0800
branch-4.1: [fix](be) Fix release build warning in column mapper #65143
(#65845)
### What problem does this PR solve?
Issue Number: None
Related PRs: #65046, #65143, #65559
Problem Summary:
PR #65559 backported the FileScannerV2 series, including #65046, to
`branch-4.1`, but did not include the follow-up Release compilation fix
#65143. With `NDEBUG`, the diagnostic uses of the two caught exceptions
are compiled out, so clang reports
`-Werror,-Wunused-exception-parameter` while compiling
`be/src/format_v2/column_mapper.cpp`.
This PR marks both catch parameters as `[[maybe_unused]]`. Debug
diagnostics and Release fallback behavior are unchanged.
Cherry-picked from #65143.
### Release note
None.
### Check List (For Author)
- Test
- [ ] Regression test
- [ ] Unit Test
- [x] Manual test
- TeamCity Doris Compile build 1001872 passed on current head
`be72438f77af633fdd9d5d84b11e30a9b8202bd1`.
- [ ] No need to test or manual test.
- Behavior changed:
- [x] No.
- [ ] Yes.
- Does this need documentation?
- [x] No.
- [ ] Yes.
### Check List (For Reviewer who merge this PR)
- [ ] Confirm the release note
- [ ] Confirm test cases
- [ ] Confirm document
- [ ] Add branch pick label
Co-authored-by: bobhan1 <[email protected]>
Co-authored-by: Dongyang Li <[email protected]>
---
be/src/format_v2/column_mapper.cpp | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/be/src/format_v2/column_mapper.cpp
b/be/src/format_v2/column_mapper.cpp
index 5d1d38eb0b3..61f35023963 100644
--- a/be/src/format_v2/column_mapper.cpp
+++ b/be/src/format_v2/column_mapper.cpp
@@ -2019,7 +2019,7 @@ Status TableColumnMapper::localize_filters(const
std::vector<TableFilter>& table
Status clone_status;
try {
clone_status =
clone_table_expr_tree(table_filter.conjunct->root(), &rewrite_root);
- } catch (const Exception& e) {
+ } catch ([[maybe_unused]] const Exception& e) {
// Some table filters contain complex intermediate values, for
example
// `element_at(MAP_VALUES(m)[1], 'age') > 30`. The current
file-local rewrite only
// understands top-level slots and struct-element paths rooted
at top-level slots;
@@ -2033,7 +2033,7 @@ Status TableColumnMapper::localize_filters(const
std::vector<TableFilter>& table
#else
continue;
#endif
- } catch (const std::exception& e) {
+ } catch ([[maybe_unused]] const std::exception& e) {
#ifndef NDEBUG
return Status::InternalError(
"Failed to clone table filter for file-local rewrite:
{}, expr={}",
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
