This is an automated email from the ASF dual-hosted git repository.
CalvinKirs pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/doris.git
The following commit(s) were added to refs/heads/master by this push:
new 88763c11858 [fix](fe) Remove oidc plugin assertions from
AuthenticationPluginManagerTest (#63323)
88763c11858 is described below
commit 88763c118581fa8bc207fccbdf6143fb5380b6a6
Author: heguanhui <[email protected]>
AuthorDate: Wed Jul 22 10:37:58 2026 +0800
[fix](fe) Remove oidc plugin assertions from
AuthenticationPluginManagerTest (#63323)
### What problem does this PR solve?
Issue Number: close #xxx
Problem Summary: `AuthenticationPluginManagerTest` asserts the existence
of an OIDC authentication plugin (`oidc`), but no OIDC plugin
implementation exists in the codebase. The `OidcPluginFactory` class
referenced in `AuthenticationPluginFactory.java` comments is only a
documentation example with no actual implementation, module, or SPI
registration. This causes `testPluginsAutoLoaded` and `testGetFactory`
to fail.
### Release note
None
### Check List (For Author)
- Test
- [x] Unit Test
- Behavior changed:
- [x] No.
- Does this need documentation?
- [x] No.
---
.../authentication/handler/AuthenticationPluginManagerTest.java | 5 -----
1 file changed, 5 deletions(-)
diff --git
a/fe/fe-authentication/fe-authentication-handler/src/test/java/org/apache/doris/authentication/handler/AuthenticationPluginManagerTest.java
b/fe/fe-authentication/fe-authentication-handler/src/test/java/org/apache/doris/authentication/handler/AuthenticationPluginManagerTest.java
index 6cde32bb90f..260afb30a96 100644
---
a/fe/fe-authentication/fe-authentication-handler/src/test/java/org/apache/doris/authentication/handler/AuthenticationPluginManagerTest.java
+++
b/fe/fe-authentication/fe-authentication-handler/src/test/java/org/apache/doris/authentication/handler/AuthenticationPluginManagerTest.java
@@ -70,7 +70,6 @@ public class AuthenticationPluginManagerTest {
// Then
Assertions.assertNotNull(pluginNames);
Assertions.assertFalse(pluginNames.isEmpty(), "Should load at least
built-in plugins");
- Assertions.assertTrue(pluginNames.contains("oidc"), "Should include
oidc plugin");
Assertions.assertTrue(pluginNames.contains("password"), "Should
include password plugin");
}
@@ -147,10 +146,6 @@ public class AuthenticationPluginManagerTest {
// Then
Assertions.assertTrue(factory.isPresent());
Assertions.assertEquals("password", factory.get().name());
-
- Optional<AuthenticationPluginFactory> oidcFactory =
pluginManager.getFactory("oidc");
- Assertions.assertTrue(oidcFactory.isPresent());
- Assertions.assertEquals("oidc", oidcFactory.get().name());
}
@Test
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
